You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Consider a better way to inject OpenTelemetry configurations to Triple protocol adaptation layer(/protocol/triple). For old Triple(/protocol/dubbo3), it retrieves configurations from config package directly. It is not a good design.
Implement OpenTelemetry Interceptor for Triple protocol. You can refer to this part(https://connectrpc.com/docs/go/observability). But there are some differences between Triple protocol and connect-go.
Tests implementation
For Triple protocol adaptation part, Please design tests to verify that OpenTelemetry configurations have been injected successfully and the necessary information in these configurations have been processed well. You can add tests in /protocol/triple/triple_test.go or some place more ideal.
For Triple protocol part, It is a good chance to learn the details about this protocol from outside to inside. You should write some unit tests to verify that OpenTelemetry Interceptor has been configured successfully and this functionality works well in the context of Triple protocol.
For dubbo-go-samples(Integration test), please refer to /tracing directory and write new tests using new API.
The text was updated successfully, but these errors were encountered:
DMwangnima
changed the title
Triple Open Tracing support
Triple OpenTelemetry support
Jan 2, 2024
What would you like to be added:
Triple OpenTelemetry support:
Consider a better way to inject OpenTelemetry configurations to Triple protocol adaptation layer(/protocol/triple). For old Triple(/protocol/dubbo3), it retrieves configurations from config package directly. It is not a good design.
Implement OpenTelemetry Interceptor for Triple protocol. You can refer to this part(https://connectrpc.com/docs/go/observability). But there are some differences between Triple protocol and connect-go.
Tests implementation
For Triple protocol adaptation part, Please design tests to verify that OpenTelemetry configurations have been injected successfully and the necessary information in these configurations have been processed well. You can add tests in /protocol/triple/triple_test.go or some place more ideal.
For Triple protocol part, It is a good chance to learn the details about this protocol from outside to inside. You should write some unit tests to verify that OpenTelemetry Interceptor has been configured successfully and this functionality works well in the context of Triple protocol.
For dubbo-go-samples(Integration test), please refer to /tracing directory and write new tests using new API.
The text was updated successfully, but these errors were encountered: