Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-34953][ci] Add github ci for flink-web to auto commit build files #732

Open
wants to merge 1 commit into
base: asf-site
Choose a base branch
from

Conversation

GOODBOY008
Copy link
Member

Changes:

  • Add github ci for flink-web to auto commit build files

@GOODBOY008
Copy link
Member Author

Comment on lines 18 to 20
pull_request:
branches:
- asf-site
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should work on PRs, but only on pushes? Else you would commit code during a PR creation?

Copy link
Member Author

@GOODBOY008 GOODBOY008 Apr 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to enable website build check for pr to avoid doc error without auto commit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But in this setup, you will always build and commit the docs as well.


- name: Commit and push website build
if: ${{ github.event_name == 'push' || github.event_name == 'workflow_dispatch' }}
uses: stefanzweifel/git-auto-commit-action@v5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per https://infra.apache.org/github-actions-policy.html we must review and pin this

echo "author=$(git log -1 --pretty=\"%an <%ae>\")" >> $GITHUB_OUTPUT

- name: Commit and push website build
if: ${{ github.event_name == 'push' || github.event_name == 'workflow_dispatch' }}
Copy link
Member Author

@GOODBOY008 GOODBOY008 Apr 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MartijnVisser With push event for pr merge into branch and workflow_dispatch for manual trigger to rebuild website.

@GOODBOY008
Copy link
Member Author

@MartijnVisser @XComp PTAL

@GOODBOY008
Copy link
Member Author

@MartijnVisser Can you give me some suggestions?

@GOODBOY008
Copy link
Member Author

GOODBOY008 commented Nov 16, 2024

@MartijnVisser @XComp
This change aims to reduce the workload for committers by automating the build and commit process for the website's generated content. Could you kindly review this PR and let me know if you have any questions or concerns? I'm happy to discuss further if needed.

The PR Funtion review:
Link: https://github.com/GOODBOY008/flink-web/commits/asf-site/
WXWorkCapture_17317273824345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants