-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-34953][ci] Add github ci for flink-web to auto commit build files #732
base: asf-site
Are you sure you want to change the base?
Conversation
The Action result: https://github.com/GOODBOY008/flink-web/commits/asf-site/ |
.github/workflows/docs.yml
Outdated
pull_request: | ||
branches: | ||
- asf-site |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this should work on PRs, but only on pushes? Else you would commit code during a PR creation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to enable website build check
for pr to avoid doc error without auto commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But in this setup, you will always build and commit the docs as well.
.github/workflows/docs.yml
Outdated
|
||
- name: Commit and push website build | ||
if: ${{ github.event_name == 'push' || github.event_name == 'workflow_dispatch' }} | ||
uses: stefanzweifel/git-auto-commit-action@v5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per https://infra.apache.org/github-actions-policy.html we must review and pin this
echo "author=$(git log -1 --pretty=\"%an <%ae>\")" >> $GITHUB_OUTPUT | ||
|
||
- name: Commit and push website build | ||
if: ${{ github.event_name == 'push' || github.event_name == 'workflow_dispatch' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MartijnVisser With push
event for pr merge into branch and workflow_dispatch
for manual trigger to rebuild website.
@MartijnVisser @XComp PTAL |
@MartijnVisser Can you give me some suggestions? |
184430d
to
e030400
Compare
@MartijnVisser @XComp The PR Funtion review: |
e030400
to
3af48b8
Compare
Changes: