-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support postgresql #240
Support postgresql #240
Conversation
@JorgeGar @matrixji @ZhangNing10 Would you like to take a look? Thanks |
Do we need to support Postgres? As #148 says, the devlake-dashboard(Grafana) currently supports MySQL syntax only. |
The issue with having PSQL supported by the helm chart is that it sends a confusing message. The chart is offering a toolset that includes both devlake and the grafana boards, but PostgreSQL is only supported by the former. |
@klesh @JorgeGar @matrixji @ZhangNing10 did you think about supporting Postgres? Looks like on the backend everything works for me with a small change: apache/incubator-devlake#7284 |
@Tonkonozhenko It would be nice if we could support both. Just like you, we have yet to figure out a generic solution so far. 😂 |
@klesh the only option I see is extracting SQL queries from dashboards' JSONs and having two queries (or if conditions) per database.
It would be great if Grafana had go templating in queries, but it only has it in alerting. |
@Tonkonozhenko Maybe you could file a feature request for Grafana? |
@klesh I'll try. For now, maybe add support to the chart? I have a working fork: main...Tonkonozhenko:incubator-devlake-helm-chart:main |
@richardinemi There is a Space at the beginning of your Connection String, right after the double-quote. |
I found the problem. It’s work now. |
Fixes #148