Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Polaris Service return wrong status when there's a location overlaps with existing catalog #503

Open
1 task done
wolflex888 opened this issue Dec 2, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@wolflex888
Copy link

Is this a possible security vulnerability?

  • This is NOT a possible security vulnerability

Describe the bug

When creating a catalog that has an overlapping location with existing catalog, the service will return 400 ( BAD_REQUEST ), but it should be 409 ( CONFLICT )

To Reproduce

Create a catalog with the same storage info location. the service will return 400 instead of 409.

Actual Behavior

The Service returns 400 ( BAD_REQUEST ) when the new catalog has a overlapping location with existing catalog.

Expected Behavior

I'm expecting the service to return 409 ( CONFLICT ) similar to catalogName conflict when creating a catalog.

Additional context

No response

System information

No response

@wolflex888 wolflex888 added the bug Something isn't working label Dec 2, 2024
@MonkeyCanCode
Copy link
Contributor

Hello @wolflex888,

Thanks for reporting this issue. Upon checking the published API doc, 409 is when the catalog name already existed instead of conflicted path: https://polaris.apache.org/in-dev/unreleased/polaris-management-service/#operation/listCatalogs.

In fact, it is possible to use overlapped path for catalogs (not by default, but with featureConfiguration.ALLOW_OVERLAPPING_CATALOG_URLS set to true...default is false).

@eric-maynard do you think we should change the status code for this one or update the code to include this as expected?

Thanks,
Yong Zheng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants