Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

76 - Remove falling back to fixed selenium executor for thumbnails by default #31843

Open
villebro opened this issue Jan 14, 2025 · 0 comments · May be fixed by #31844
Open

76 - Remove falling back to fixed selenium executor for thumbnails by default #31843

villebro opened this issue Jan 14, 2025 · 0 comments · May be fixed by #31844
Assignees
@villebro
Labels
alert-reports Namespace | Anything related to the Alert & Reports feature

Comments

@villebro
Copy link
Member

Currently we have

THUMBNAIL_SELENIUM_USER: str | None = "admin"
THUMBNAIL_EXECUTE_AS = [ExecutorType.CURRENT_USER, ExecutorType.SELENIUM]

I propose we change the name of the config + remove defaulting to it

THUMBNAIL_FIXED_USER: str | None = None
THUMBNAIL_EXECUTE_AS = [ExecutorType.CURRENT_USER]

Same for Alerts & Reports
@villebro villebro self-assigned this Jan 14, 2025
@villebro villebro converted this from a draft issue Jan 14, 2025
@villebro villebro linked a pull request Jan 14, 2025 that will close this issue
Draft
9 tasks
@dosubot dosubot bot added the alert-reports Namespace | Anything related to the Alert & Reports feature label Jan 14, 2025
@villebro villebro moved this from Lazy Consensus Reached to Work in Progress in Apache Superset 5.0 Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@villebro villebro

Labels
alert-reports Namespace | Anything related to the Alert & Reports feature
Projects
Apache Superset 5.0
Status: Work in Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: replace selenium user with fixed user villebro/superset
1 participant
@villebro