-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIP-154] Optional dataset folders #32351
Comments
This is a super cool advancement! Let's put it up for [discuss], but you have my +1 when the vote comes! |
Thank you for the SIP @betodealmeida. Some questions:
|
Very cool! In the picture of the Explorer, only Metrics are shown; how would this look with columns? |
That's a good point @mattitoo. For datasets with many column groups, the metrics might end up always hidden due to scroll. |
Thanks for the comments, @michael-s-molina! Here are some clarifications:
You can click the checkboxes on the left, and move the group of selected metrics/columns into a folder. But the feature is (at least initially) intended to create small curated folders, so there are no planned affordances to select hundreds of metrics/columns with a single action (say, by searching and clicking a "select all" button). You still need to check each checkbox individually.
Yes, we don't have screenshots yet but it's the standard Superset flow, similar to dashboard titles, for example. You click on the name and becomes editable, you press enter and it's saved.
They are displayed as today, under Metrics and Columns. You can see it on the second screenshot, which has some leftover metrics (but no columns). If there are no custom folders Explore will look exactly the same as today.
No, search will filter only metrics and columns. Any folders without matches will still be visibile, even if empty.
"Reset all folders to default" will move all metrics and columns out of the folders, after confirmation. Any created folders would remain, although empty. |
Just like today. In the second screenshot all coluns have been moved out to folders, so the secion doesn't show up.
That's a good point. Today we cap the list of metrics/columns displayed in Explore, showing only the first 50 followed by a "Show all..." button. We would do the same for these folders, and the current search functionality would work with folders as well. I like the idea of making the collapse. An easy way to do this would be storing the state in the browser, since some folders might be interesting to some users but not others. |
[SIP-154] Optional dataset folders
Motivation
It's not uncommon for core datasets to have hundreds or even thousands (!) of columns/metrics. Exploring these datasets is cumbersome, forcing users to know their names beforehand, so they can search for them in the chart builder UI. Even with small datasets, knowing columns and/or metrics are important can be unclear.
Proposed Change
To address this problem this SIP proposes a worfklow in which metrics and columns in a dataset can be organized into folders (figure 1). The folders are surfaced in the chart builder UI, allowing for quicker and more confident exploration of the metrics and columns (figure 2).
A few clarifications:
New or Changed Public Interfaces
No new APIs are needed, but the dataset CRUD API will be extended to support folders.
New dependencies
No new dependencies.
Migration Plan and Compatibility
The feature is optional, and old datasets wlil work as today (without any custom folders), so there's no need for migrations.
Rejected Alternatives
An alternative would be to create new datasets with a subset of the metric and columns of a given dataset, but that could lead to the excessive proliferation of datasets, and different datasets could fall out of sync.
The text was updated successfully, but these errors were encountered: