Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(country-map): add map for France with all overseas territories #31037

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tarraschk
Copy link

SUMMARY

This PR adds a GeoJSON map for France with all overseas territories in the "Country maps" charts.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

TESTING INSTRUCTIONS

  1. Create a new chart
  2. Choose dataset "birth_france_by_region" (built-in)
  3. Choose a "Country Map" chart type
  4. In Country option choose "France (with overseas)", DEPT_ID for ISO 3166-2 code, and avg__204 for Metric.
  5. Click on Create Chart

image

ADDITIONAL INFORMATION

  • Has associated issue: Add a map of France with overseas (ready to make the PR if approved) #30994
  • Required feature flags: viz:charts:map
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the viz:charts:map Related to Map charts label Nov 24, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@tarraschk tarraschk changed the title feat(countr-map): add map for France with all overseas territories feat(country-map): add map for France with all overseas territories Nov 24, 2024
@rusackas
Copy link
Member

Hi! I appreciate the change, but the change needs to be made in the Jupyter notebook. I hope this helps :)

@tarraschk
Copy link
Author

Hi! I appreciate the change, but the change needs to be made in the Jupyter notebook. I hope this helps :)

Hello @rusackas thanks for your feedback.

The GeoJSON has been made by hand in order to simplify some geometries (e.g. French Polynesia has a lot of islands, but I only kept the main one which is Tahiti).
Thus, can I upload it on a private repo, and then sync it with Jupyter like it has been done for India here?

image

@github-actions github-actions bot added the doc Namespace | Anything related to documentation label Nov 26, 2024
@tarraschk
Copy link
Author

@rusackas I adapted my PR with your recommendations.

  1. I created a geojson and hosted it on my own repo.
  2. I updated the Jupyter Notebook project so that it takes my geojson file, based on the same approach as the one used for Philippines.

I added a step to plot all countries from the "altmaps" in order to preview all maps that are a little more customized. We can see the new France Overseas results right here :).

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Namespace | Anything related to documentation plugins size/XL viz:charts:map Related to Map charts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants