-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(country-map): add map for France with all overseas territories #31037
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bb01bc4
to
a55d260
Compare
Hi! I appreciate the change, but the change needs to be made in the Jupyter notebook. I hope this helps :) |
Hello @rusackas thanks for your feedback. The GeoJSON has been made by hand in order to simplify some geometries (e.g. French Polynesia has a lot of islands, but I only kept the main one which is Tahiti). |
a55d260
to
a54d9fb
Compare
@rusackas I adapted my PR with your recommendations.
I added a step to plot all countries from the "altmaps" in order to preview all maps that are a little more customized. We can see the new France Overseas results right here :). |
SUMMARY
This PR adds a GeoJSON map for France with all overseas territories in the "Country maps" charts.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
viz:charts:map