fix(dev/ci): pre-commit fixes galore #32352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
doc
rusackas
requested review from
villebro,
geido,
eschutho,
betodealmeida,
nytai,
mistercrunch,
craig-rueda,
kgabryje and
dpgaspar
as code owners
github-actions
bot
added
the
github_actions
github-actions
bot
added
risk:db-migration
|
@rusackas Ephemeral environment spinning up at http://54.186.129.54:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup. |
|
/korbit-review |
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Fix Detected |
|---|---|---|
 |
Redundant language module declarations ▹ view |
Files scanned
Due to the exceptionally large size of this PR, I've limited my review to the following files:
| File Path | Reviewed |
|---|---|
| docs/babel.config.js | ✅ |
| docs/src/utils.js | ✅ |
| superset-frontend/packages/superset-ui-demo/storybook/stories/plugins/legacy-preset-chart-nvd3/BoxPlot/NVD3BoxPlot.stories.tsx | ✅ |
| docs/static/script/matomo.js | ✅ |
| superset/common/db_query_status.py | ✅ |
| superset-frontend/packages/superset-ui-demo/storybook/stories/plugins/legacy-plugin-chart-chord/LegacyPluginChartChord.stories.tsx | ✅ |
| superset-frontend/packages/superset-ui-demo/storybook/stories/plugins/plugin-chart-echarts/Gauge/Gauge.stories.tsx | ✅ |
| superset-frontend/packages/superset-ui-demo/storybook/stories/plugins/plugin-chart-echarts/Graph/Graph.stories.tsx | ✅ |
| superset-frontend/packages/superset-ui-demo/storybook/stories/superset-ui-color/RenderPalettes.tsx | ✅ |
| superset-frontend/packages/superset-ui-demo/storybook/stories/plugins/plugin-chart-echarts/Waterfall/Waterfall.stories.tsx | ✅ |
| superset-frontend/packages/superset-ui-demo/storybook/stories/plugins/plugin-chart-echarts/Radar/Radar.stories.tsx | ✅ |
| superset-frontend/packages/superset-ui-demo/storybook/shared/components/ResizablePanel.tsx | ✅ |
| superset-frontend/packages/superset-ui-demo/storybook/stories/plugins/plugin-chart-pivot-table/PivotTable.stories.tsx | ✅ |
| docs/src/theme/DocItem/index.js | ✅ |
| docs/src/components/SectionHeader.tsx | ✅ |
| superset/db_engine_specs/hana.py | ✅ |
| docs/.eslintrc.js | ✅ |
| superset-frontend/src/types/react-syntax-highlighter.d.ts | ✅ |
| superset-frontend/packages/superset-ui-demo/storybook/stories/plugins/plugin-chart-table/testData.ts | ✅ |
| superset/cli/thumbnails.py | ✅ |
| superset-frontend/packages/superset-ui-demo/storybook/shared/components/ResizableChartDemo.tsx | ✅ |
| superset/utils/pandas_postprocessing/histogram.py | ✅ |
| superset/db_engine_specs/oracle.py | ✅ |
| superset-frontend/src/explore/actions/datasourcesActions.ts | ✅ |
| docs/sidebars.js | ✅ |
| superset-frontend/packages/superset-ui-demo/storybook/stories/plugins/legacy-plugin-chart-country-map/CountryMap.stories.tsx | ✅ |
| superset-frontend/packages/superset-ui-demo/storybook/stories/superset-ui-style/Theme.stories.tsx | ✅ |
| docker/pythonpath_dev/superset_config.py | ✅ |
| superset-frontend/packages/superset-ui-demo/storybook/stories/plugins/plugin-chart-table/Table.stories.tsx | ✅ |
| superset/migrations/versions/2020-09-28_17-57_b56500de1855_add_uuid_column_to_import_mixin.py | ✅ |
| superset-frontend/packages/superset-ui-demo/storybook/stories/superset-ui-number-format/NumberFormat.stories.tsx | ✅ |
| superset-frontend/packages/superset-ui-demo/storybook/stories/superset-ui-time-format/TimeFormat.stories.tsx | ✅ |
| superset-frontend/packages/superset-ui-demo/storybook/stories/plugins/plugin-chart-echarts/Timeseries/Timeseries.stories.tsx | ✅ |
| scripts/cancel_github_workflows.py | ✅ |
| superset/queries/api.py | ✅ |
| superset/db_engine_specs/couchbase.py | ✅ |
| docs/src/pages/community.tsx | ✅ |
| superset/db_engine_specs/duckdb.py | ✅ |
| superset/db_engine_specs/snowflake.py | ✅ |
| RELEASING/changelog.py | ✅ |
| docs/docusaurus.config.ts | ✅ |
| superset/sqllab/api.py | ✅ |
| superset/dashboards/schemas.py | ✅ |
| superset/db_engine_specs/databricks.py | ✅ |
| docs/src/pages/index.tsx | ✅ |
| superset/db_engine_specs/hive.py | ✅ |
| superset/tags/api.py | ✅ |
| superset/sql_lab.py | ✅ |
| superset/migrations/versions/2022-04-01_14-38_a9422eeaae74_new_dataset_models_take_2.py | ✅ |
| superset/charts/api.py | ✅ |
| superset/datasets/api.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ❌ Issue Categories
Category Enabled Documentation ✅ Logging ✅ Error Handling ✅ Readability ✅ Design ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
Comment on lines
29
to
47
| declare module 'react-syntax-highlighter/dist/cjs/languages/hljs/markdown' { | ||
| const language: any; | ||
| export default language; | ||
| } | ||
|
|
||
| declare module 'react-syntax-highlighter/dist/cjs/languages/hljs/htmlbars' { | ||
| const language: any; | ||
| export default language; | ||
| } | ||
|
|
||
| declare module 'react-syntax-highlighter/dist/cjs/languages/hljs/sql' { | ||
| const language: any; | ||
| export default language; | ||
| } | ||
|
|
||
| declare module 'react-syntax-highlighter/dist/cjs/languages/hljs/json' { | ||
| const language: any; | ||
| export default language; | ||
| } |
There was a problem hiding this comment.
Redundant language module declarations 
Tell me more
What is the issue?
Repeated module declarations with identical structure violate the DRY principle and make maintenance more difficult.
Why this matters
If the structure of these language modules needs to change in the future, developers would need to update multiple identical declarations, increasing the risk of inconsistencies and maintenance overhead.
Suggested change ∙ Feature Preview
Create a type helper or utility to declare language modules:
type HighlighterLanguage = { language: any };
function declareLanguageModule(name: string) {
return `declare module 'react-syntax-highlighter/dist/cjs/languages/hljs/${name}' {
const language: any;
export default language;
}`;
}
// Or use a string literal union type
type SupportedLanguages = 'markdown' | 'htmlbars' | 'sql' | 'json';
declare module 'react-syntax-highlighter/dist/cjs/languages/hljs/*' {
const language: any;
export default language;
}
💬 Chat with Korbit by mentioning @korbit-ai.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When running
pre-commit run --all-filesI was getting a TON of console noise, TS errors, lint errors, etc. This should tidy things up significantly, fixing all the errors, improving the eslint process for docs, and more.It also updates a couple of newer pre-commit hooks/linters to newer version, and makes changes accordingly.
One migration caught a hypothetical security issue, and that was addressed as well.
Frontend pre-commit jobs (prettier/eslint) now write fixes when run locally, so you can re-run and pass, but do not do this on CI, so they appropriately fail.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Let's see if CI passes!
ADDITIONAL INFORMATION