fix: Clicking in the body of a Markdown component does not put it into edit mode #32384
Conversation
…does not put it into edit mode
dosubot
bot
added
dashboard:editmode
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Fix Detected |
|---|---|---|
 |
Incorrect Event Propagation Logic ▹ view | |
 |
Redundant State Update in Click Handler ▹ view |
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/dashboard/components/menu/WithPopoverMenu.tsx | ✅ |
| superset-frontend/src/dashboard/components/gridComponents/Markdown.jsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ❌ Issue Categories
Category Enabled Documentation ✅ Logging ✅ Error Handling ✅ Readability ✅ Design ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
| if (shouldFocusComponent) { | ||
| event.stopPropagation(); | ||
| } |
There was a problem hiding this comment.
Incorrect Event Propagation Logic 
Tell me more
What is the issue?
The event.stopPropagation() is called when shouldFocusComponent is true, which contradicts the comment 'Allow the event to propagate to the Markdown component' and the intended behavior.
Why this matters
This will prevent the click event from reaching the Markdown component when we actually want it to be editable, potentially breaking the main feature this PR aims to implement.
Suggested change ∙ Feature Preview
The event.stopPropagation() should be removed or the logic should be inverted depending on the exact desired behavior. If we want to allow propagation to Markdown, simply remove these lines:
if (shouldFocusComponent) {
event.stopPropagation();
}
💬 Chat with Korbit by mentioning @korbit-ai.
| onClick={() => { | ||
| if (editMode) { | ||
| this.handleChangeFocus(true); | ||
| this.handleChangeEditorMode('edit'); | ||
| } | ||
| }} |
There was a problem hiding this comment.
Redundant State Update in Click Handler 
Tell me more
What is the issue?
Redundant call to handleChangeEditorMode('edit') since handleChangeFocus(true) already triggers edit mode
Why this matters
The redundant call creates unnecessary state updates and could potentially cause race conditions or unexpected behavior in the component's state management
Suggested change ∙ Feature Preview
Remove the redundant call to handleChangeEditorMode and only use handleChangeFocus:
onClick={() => {
if (editMode) {
this.handleChangeFocus(true);
}
}}💬 Chat with Korbit by mentioning @korbit-ai.
sadpandajoe
changed the title
…does not put it into edit mode
|
I see it's passing CI, excellent! I don't know enough front end to review but hopefully @rusackas can take a look or tag another reviewer. |
fixes: #32252
Solved Issue of not able to switch to edit mode when clicking on div.