fix(model/helper): represent RLS filter clause in proper textual SQL string

[hainenber]

fix(model/helper): represent RLS filter clause in proper textual SQL string

SUMMARY

Fixes #32394 (thanks @propellerjet for finding out the issue!)

The filter clause in Row Level Security (RLS) might not play well with percentage sign used in LIKE syntax. This PR is to fix that

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

After

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[korbit-ai]

I've completed my review and didn't find any issues.

Files scanned

​

File Path	Reviewed
superset/models/helpers.py	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

• You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
• You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
• Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
• Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
• Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

• Check out our docs on how you can make Korbit work best for you and your team.
• Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings

​

Setting	Value
Review Schedule	Automatic excluding drafts
Max Issue Count	10
Automatic PR Descriptions	❌

Issue Categories

​

Category	Enabled
Documentation	✅
Logging	✅
Error Handling	✅
Readability	✅
Design	✅
Performance	✅
Security	✅
Functionality	✅

Feedback and Support

• Tell us what you think of Korbit
• Schedule a call with our team
• Email us @ [email protected]

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.40%. Comparing base (76d897e) to head (15df54b).
Report is 1497 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #32406       +/-   ##
===========================================
+ Coverage   60.48%   76.40%   +15.91%     
===========================================
  Files        1931      546     -1385     
  Lines       76236    39091    -37145     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    29867    -16247     
+ Misses      28017     9224    -18793     
+ Partials     2105        0     -2105     

Flag	Coverage Δ
hive	48.52% <0.00%> (-0.64%)	⬇️
javascript	?
mysql	75.86% <100.00%> (?)
postgres	75.93% <100.00%> (?)
presto	53.05% <0.00%> (-0.75%)	⬇️
python	76.40% <100.00%> (+12.91%)	⬆️
sqlite	75.44% <100.00%> (?)
unit	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.