From 9b2dcbe612427035d01bdc8310edceaf3ccc188f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rouven=20We=C3=9Fling?= <rouven@contentful.com>
Date: Fri, 27 Nov 2020 17:19:17 +0100
Subject: [PATCH] Move url to dev dependencies

It's only needed when bundling for the browser
---
 package-lock.json | 7 +++++--
 package.json      | 6 +++---
 rollup.config.js  | 5 +++++
 3 files changed, 13 insertions(+), 5 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index fa43a6d8..993460c9 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -8341,7 +8341,8 @@
     "querystring": {
       "version": "0.2.0",
       "resolved": "https://registry.npmjs.org/querystring/-/querystring-0.2.0.tgz",
-      "integrity": "sha1-sgmEkgO7Jd+CDadW50cAWHhSFiA="
+      "integrity": "sha1-sgmEkgO7Jd+CDadW50cAWHhSFiA=",
+      "dev": true
     },
     "quick-lru": {
       "version": "4.0.1",
@@ -9855,6 +9856,7 @@
       "version": "0.11.0",
       "resolved": "https://registry.npmjs.org/url/-/url-0.11.0.tgz",
       "integrity": "sha1-ODjpfPxgUh63PFJajlW/3Z4uKPE=",
+      "dev": true,
       "requires": {
         "punycode": "1.3.2",
         "querystring": "0.2.0"
@@ -9863,7 +9865,8 @@
         "punycode": {
           "version": "1.3.2",
           "resolved": "https://registry.npmjs.org/punycode/-/punycode-1.3.2.tgz",
-          "integrity": "sha1-llOgNvt8HuQjQvIyXM7v6jkmxI0="
+          "integrity": "sha1-llOgNvt8HuQjQvIyXM7v6jkmxI0=",
+          "dev": true
         }
       }
     },
diff --git a/package.json b/package.json
index 639d2ecf..0576c1b2 100644
--- a/package.json
+++ b/package.json
@@ -47,8 +47,7 @@
     "http-string-parser": "0.0.6",
     "json-pointer": "0.6.0",
     "media-typer": "1.1.0",
-    "tv4": "1.3.0",
-    "url": "0.11.0"
+    "tv4": "1.3.0"
   },
   "devDependencies": {
     "@rollup/plugin-json": "4.0.1",
@@ -70,7 +69,8 @@
     "rollup-plugin-node-resolve": "5.2.0",
     "rollup-plugin-terser": "7.0.2",
     "semantic-release": "17.2.3",
-    "sinon": "7.5.0"
+    "sinon": "7.5.0",
+    "url": "0.11.0"
   },
   "repository": {
     "type": "git",
diff --git a/rollup.config.js b/rollup.config.js
index 57103cc4..de0313be 100644
--- a/rollup.config.js
+++ b/rollup.config.js
@@ -42,6 +42,11 @@ const buildCjs = {
       return true;
     }
 
+    // url is a built-in module and should not be bundled either
+    if (id === 'url') {
+      return true;
+    }
+
     return false;
   },
   plugins: [