Skip to content

Commit 21d0837

Browse files
committed
chore: github UX
1 parent b2d2568 commit 21d0837

File tree

2 files changed

+17
-3
lines changed

2 files changed

+17
-3
lines changed

.github/PULL_REQUEST_TEMPLATE.md

+13-2
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,19 @@ What's changed, or what was fixed?
1212
- [ ] I have run all the tests locally and they all pass.
1313
- [ ] I have followed the relevant style guide for my changes.
1414

15-
## Full Repo Validation Required
16-
(please check all that apply [x], do not edit the text)
15+
## ADVANCED Settings
16+
17+
For most PRs you most likely do not have to edit anything in this section.
18+
19+
### Test Scope
20+
21+
By default the PR pipeline tests all projects that were edited in the PR.
22+
23+
Some PRs might have side-effects on other projects such as changes to the test pipeline or shared tooling and need tests beyond the projects edited in this PR.
24+
25+
To customize the PR testing scope check [x] either option below and replace the sub-projects as needed.
26+
1727
- [ ] PR requires full pipeline run (Run for changes only by default).
28+
- [ ] Test following projects (comma separated list): references/cicd-pipeline,tools/apigee-sackmesser
1829

1930
**CC:** @apigee-devrel-reviewers

tools/pipeline-runner/github-api.sh

+4-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@
1818

1919
buildresult=$(cat)
2020

21-
REPORT_ROWS=$(echo "$buildresult" | awk -F";" '$2 = ($2 == "fail" ? "❌" : "✅") ; $0="|"$1"|"$2"|"$3"|"' OFS="|")
21+
REPORT_ROWS=$(echo "$buildresult" | awk -F, -v OFS='|' '{gsub(/pass/, "✅"); gsub(/fail/, "❌"); print "|" $1 "|" $2 "|" $3 "|"}')
22+
2223
REPORT=$(cat <<EOF
2324
### Pipeline Report
2425
@@ -32,6 +33,8 @@ Commit version: $SHORT_SHA
3233
EOF
3334
)
3435

36+
echo $REPORT
37+
3538
REPO_API="https://api.github.com/repos/$REPO_GH_ISSUE"
3639

3740
createIssueComment() {

0 commit comments

Comments
 (0)