-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update rover's introspection to the new version of apollo-rs libraries #675
Comments
As far as I can tell for this purpose rover has:
|
In PR #758 we recently introduced "server-side" support for introspection in apollo-compiler. So I think it’d make sense to provide this "client-side" functionality in apollo-compiler as well, not just in Rover. |
I gave this a quick shot a few weeks back (https://github.com/apollographql/rover/tree/apollo-1.0) until I hit #761 and figured it was maybe not our top priority. But it should not be a lot of work to complete. Moving (part of) that into apollo-rs could definitely make sense |
If nothing extraordinary comes up, I think we can safely postpone this work til February next year. |
Fixes #675 Requests `__Directive.isRepeatable` and `__Type.specifiedByURL`, which Rover does not: https://github.com/apollographql/rover/blob/fb68f7bf96/crates/rover-client/src/operations/graph/introspect/introspect_query.graphql
Rover currently uses
apollo-encoder
to serialise incoming serde_json introspection result into SDL. With the new introspection and execution code, and the upcoming1.0.0
release ofapollo-compiler
we need to update Rover to a new way of encoding serde_json to SDL.The text was updated successfully, but these errors were encountered: