Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generated completions don't pass shell check #703

Open
rauhul opened this issue Feb 6, 2025 · 4 comments
Open

generated completions don't pass shell check #703

rauhul opened this issue Feb 6, 2025 · 4 comments

Comments

@rauhul
Copy link
Contributor

rauhul commented Feb 6, 2025

completions fail shell check with both warnings and errors

@rgoldberg
Copy link
Contributor

@rauhul My existing local branch for #679 probably fixes all such issues. Can you delay working on this so I can see if I can easily I split out those changes?

@rauhul
Copy link
Contributor Author

rauhul commented Feb 7, 2025

Sure, please check out #695 though, I'd like to merge that tomorrow if possible

@rgoldberg
Copy link
Contributor

@rauhul I've started to make comments on the PR, but I'm not yet done. Are they visible to you?

Most are minor, but there is an issue with not outputting cases for arguments that don't have completions.

I don't have the ability to approve PRs, as I'm not a project member.

I'll need to rebase my #679 branch on the new main. I also need #707 to be merged, as I'm stuck using Swift 5.7.

Are you planning on modifying the completion code any more, besides for this issue?

@rgoldberg
Copy link
Contributor

@rauhul Are you using anything besides shellcheck 0.10.0?

Obviously, that won't work for fish, and only partially works for zsh.

Do you want shellcheck failures in zsh scripts ignored via comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants