-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generated completions don't pass shell check #703
Comments
Sure, please check out #695 though, I'd like to merge that tomorrow if possible |
@rauhul I've started to make comments on the PR, but I'm not yet done. Are they visible to you? Most are minor, but there is an issue with not outputting cases for arguments that don't have completions. I don't have the ability to approve PRs, as I'm not a project member. I'll need to rebase my #679 branch on the new Are you planning on modifying the completion code any more, besides for this issue? |
@rauhul Are you using anything besides Obviously, that won't work for fish, and only partially works for zsh. Do you want |
completions fail shell check with both warnings and errors
The text was updated successfully, but these errors were encountered: