Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate docs for NIO Transport Services #14

Open
tkrajacic opened this issue Dec 1, 2018 · 4 comments
Open

Generate docs for NIO Transport Services #14

tkrajacic opened this issue Dec 1, 2018 · 4 comments
Labels
kind/bug Feature doesn't work as expected.

Comments

@tkrajacic
Copy link
Contributor

Currently the Readme suggests

NIOTS provides an alternative EventLoop, EventLoopGroup, and several alternative Channels and Bootstraps

however there are no links to the actual alternative types provided by swift-nio-transport-services.

Using the ClientBootstrap from swift-nio for example would result in a runtime crash.

Could not cast value of type 'NIOTransportServices.NIOTSEventLoop' (0x1007c5a88) to 'NIO.SelectableEventLoop' (0x100513f90).
2018-11-30 20:24:55.782576+0100 NIOTest[24746:16198029] Could not cast value of type 'NIOTransportServices.NIOTSEventLoop' (0x1007c5a88) to 'NIO.SelectableEventLoop' (0x100513f90).

This is not obvious from going through the documentation.

It would be great if

  • swift-nio-transport-services would document its own types that augment those of swift-nio
  • the swift-nio documentation could add a note on using different types for users of swift-nio-transport-services
@weissi
Copy link
Member

weissi commented Mar 20, 2019

@tomerd

@weissi weissi added the kind/bug Feature doesn't work as expected. label Mar 26, 2019
@Yasumoto
Copy link

🤔 Any chance the docs I was hoping for in apple/swift-nio#674 could come out of this?

@weissi
Copy link
Member

weissi commented Jul 17, 2019

yeah, we need to get our act together here.

@weissi
Copy link
Member

weissi commented Jul 17, 2019

oh shoot, they're still not even generated for NIOTS. Let's fix that first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Feature doesn't work as expected.
Projects
None yet
Development

No branches or pull requests

3 participants