Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge WIZnet fork #230

Closed
marek22k opened this issue Sep 6, 2023 · 1 comment
Closed

Merge WIZnet fork #230

marek22k opened this issue Sep 6, 2023 · 1 comment
Assignees
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: enhancement Proposed improvement

Comments

@marek22k
Copy link

marek22k commented Sep 6, 2023

WIZnet has made some new chips and it would be nice if someone could merge the PRs.

#185
#101
#102

Ping on maintainers: @per1234 @facchinm @aentinger @karlsoderby @cmaglie @PaulStoffregen

@per1234 per1234 self-assigned this Sep 7, 2023
@per1234 per1234 added topic: code Related to content of the project itself type: enhancement Proposed improvement labels Sep 7, 2023
@per1234
Copy link
Contributor

per1234 commented Sep 7, 2023

Hi @marek22k. Thanks for your interest in this open source project. The pull requests are sufficient for us to track the task of reviewing those proposals. Since this additional issue is superfluous, I'll go ahead and close it in the interest of keeping the repository tidy.

You are welcome to do careful and thorough testing and code review of those pull requests and then submit your findings via the GitHub pull request review system:

https://docs.github.com/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/about-pull-request-reviews

@per1234 per1234 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2023
@per1234 per1234 added the conclusion: duplicate Has already been submitted label Sep 7, 2023
@arduino-libraries arduino-libraries locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

No branches or pull requests

2 participants