Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion of pebble movement infrastructure #3

Closed
ZoeRichter opened this issue May 13, 2024 · 2 comments
Closed

Discussion of pebble movement infrastructure #3

ZoeRichter opened this issue May 13, 2024 · 2 comments
Assignees
Labels
Comp:Core This issue has to do with the main bulk of the code or document. (methods, main content) Priority:2-Normal This work is important and should be completed ASAP. Status:1-New No one has claimed this issue yet. It is in need of solving. Type:Question This issue can be closed with a discussion and/or an answer.

Comments

@ZoeRichter
Copy link
Collaborator

This issue is for workshopping the broader code infrastructure didymus will use for moving pebbles within an active core. While there will be multiple modes of movement, there will be a necessity for tracking pebble data that they will share (at the very least).

didymus will need to track:

  • pebble material
  • a pebble's unique ID, which should not change over the pebble's lifetime
  • number of passes each pebble has made (for a mulitpass cycle)
  • If a pass would cause a pebble's material to change (for example, if material is determined by pass, and a pebble leaves its first pass and goes to its second) then didymus needs to be able to recognize this, identify what material it currently is, and update it to the corresponding new material
  • pebble discharge criterion (once a pebble has been discharged, should its unique ID be retired as well, or reused?) (should didymus create some sort of output tracking pebbles that exit the core, and when?)

(this initial list may be updated if more things to track are thought of)

@ZoeRichter ZoeRichter self-assigned this May 13, 2024
@ZoeRichter ZoeRichter added Comp:Core This issue has to do with the main bulk of the code or document. (methods, main content) Priority:2-Normal This work is important and should be completed ASAP. Status:1-New No one has claimed this issue yet. It is in need of solving. Type:Question This issue can be closed with a discussion and/or an answer. labels May 13, 2024
@katyhuff
Copy link
Member

  • pebble material
    • less get some more fidelity on what this means.... maybe material composition/isotopic vector (or what Cyclus calls "compID") ?
  • a pebble's unique ID, which should not change over the pebble's lifetime
    • yes
  • number of passes each pebble has made (for a mulitpass cycle)
    • yes
  • If a pass would cause a pebble's material to change (for example, if material is determined by pass, and a pebble leaves its first pass and goes to its second) then didymus needs to be able to recognize this, identify what material it currently is, and update it to the corresponding new material
    • all passes will change the material composition
    • definitely review cyclus approach here
  • pebble discharge criterion (once a pebble has been discharged, should its unique ID be retired as well, or reused?) (should didymus create some sort of output tracking pebbles that exit the core, and when?)
    • do not reuse unique ids.

@katyhuff katyhuff added this to the Establish Code Structure milestone May 31, 2024
@katyhuff
Copy link
Member

This issue can be closed with a short description of the proposed structure of capabilities to be implemented in didymus and discussion of complementary capabilities potentially to be implemented in other tools. This could be executed as a .rst file in the docs directory of didymus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Comp:Core This issue has to do with the main bulk of the code or document. (methods, main content) Priority:2-Normal This work is important and should be completed ASAP. Status:1-New No one has claimed this issue yet. It is in need of solving. Type:Question This issue can be closed with a discussion and/or an answer.
Projects
None yet
Development

No branches or pull requests

2 participants