feat(anta): Added the test case to verify the SNMP source interface for specified VRF #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #870 will not alter performanceComparing Summary
|
MaheshGSLAB
reviewed
Oct 11, 2024
anta/tests/snmp.py
Outdated
|
|
||
| # Verify source-interface details. | ||
| if not actual_interface: | ||
| failures += f"Source interface '{interface}' is not configured.\n" |
There was a problem hiding this comment.
Suggested change
| failures += f"Source interface '{interface}' is not configured.\n" | |
| failures += f"Source interface '{interface}' is not configured with vrf `{vrf}`.\n" |
MaheshGSLAB
reviewed
Oct 11, 2024
anta/tests/snmp.py
Outdated
| if not actual_interface: | ||
| failures += f"Source interface '{interface}' is not configured.\n" | ||
| elif actual_interface != interface: | ||
| failures += f"Source interface '{interface}' is not correctly configured in vrf '{vrf}'.\n" |
There was a problem hiding this comment.
again what is expected and what actual interface received please mention that in failure message.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
vitthalmagadum
force-pushed
the
issue_854
branch
from
b765061 to
85574fc
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Verifies SNMP source-interface for a specified VRF.
Fixes #854
Checklist:
pre-commit run)tox -e testenv)