Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): add L3 Portchannel and L3 Portchannel members to the documentation #5092

Draft
wants to merge 5 commits into
base: devel
Choose a base branch
from

Conversation

bjmeuer
Copy link
Contributor

@bjmeuer bjmeuer commented Feb 24, 2025

Change Summary

add L3 Portchannel and L3 Portchannel members to the documentation

Related Issue(s)

Fixes #5091

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

add L3 Portchannel and L3 Portchannel members to the documentation

How to test

Checklist

User Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@bjmeuer bjmeuer requested review from a team as code owners February 24, 2025 15:23
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-5092
# Activate the virtual environment
source test-avd-pr-5092/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/bjmeuer/avd.git@eos_cli_gen_PO_docu#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/bjmeuer/avd.git#/ansible_collections/arista/avd/,eos_cli_gen_PO_docu --force
# Optional: Install AVD examples
cd test-avd-pr-5092
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Feb 24, 2025
@ClausHolbechArista
Copy link
Contributor

As discussed offline, moving this one to draft, since it clearly shows we need to rewamp the entire interface documentation style. We will discuss and handle the implementation. This PR will likely be closed, but kept here for now to remind us :)

@ClausHolbechArista ClausHolbechArista marked this pull request as draft February 26, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): add L3 Portchannel and L3 Portchannel members to the documentation
2 participants