Fix(eos_cli_config_gen): Fix the exit of name-server group between vrf host and root in monitor connectivity #5134
+34
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
state: CI Updated
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-5134
# Activate the virtual environment
source test-avd-pr-5134/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@fix-ip-names-server-group#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,fix-ip-names-server-group --force
# Optional: Install AVD examples
cd test-avd-pr-5134
ansible-playbook arista.avd.install_examples |
laxmikantchintakindi
force-pushed
the
fix-ip-names-server-group
branch
from
0cff982 to
1a79b81
Compare
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/monitor-connectivity.j2
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/monitor-connectivity.j2
Show resolved
Hide resolved
…f host and root in monitor connectivity
…onnectivity.j2 Co-authored-by: Claus Holbech <[email protected]>
…onnectivity.j2 Co-authored-by: Claus Holbech <[email protected]>
laxmikantchintakindi
force-pushed
the
fix-ip-names-server-group
branch
from
fa5b8fd to
70491f0
Compare
|
MaheshGSLAB
reviewed
Mar 7, 2025
| @@ -54,8 +54,14 @@ monitor connectivity | |||
| url {{ host.url }} | |||
| {% endif %} | |||
| {% endif %} | |||
| ! | |||
There was a problem hiding this comment.
Why we need exclamation mark? exit should fix the issue
There was a problem hiding this comment.
Please test it by deploy via cvp/eapi. Also we need to test it with reboot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fix the exit of name-server group between vrf host and root in monitor connectivity
Related Issue(s)
Fixes #5133
Component(s) name
arista.avd.eos_cli_config_genProposed changes
When pushed below configuration to eos, it generates wrong configs.
Intended configs -
Show running config:
How to test
Checklist
User Checklist
Repository Checklist