ARQ-2231 The JUnit 5 container does not work with manual mode tests #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamezp
approved these changes
Apr 3, 2024
petrberan
requested changes
Apr 4, 2024
There was a problem hiding this comment.
Just putting it here, but this fails main branch build of https://github.com/jbossws/jbossws-cxf
|
Thanks @petrberan for pointing this out - given that the cxf testsuite is doing pretty convoluted code paths, until we figure our where the problem is, converting to draft. Perhaps the double events are now defacto the norm. |
|
I don't know how we can stop these things from happening twice, but if I use this PR and add an empty |
jamezp
approved these changes
Jun 28, 2024
…reEachCallback.beforeEach handle events within the interceptor
|
Thanks @jamezp Rebased only now to remove the merge commits/pull in latest changes and run CI, no changes. |
jamezp
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ARQ-2231