-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[580] Create some integration tests. Create profiles for WildFly to r… #581
Conversation
See https://github.com/flowlogix/base-pom the way I did this for Payara so that profiles are not repeated for every project. |
@jamezp What about not having this inherrit the arquillian-parent pom and only use the bom? The reason is that it can be used to test any version of arquillian-core. For example, I have a local 1.9.0.Final-SNAPSHOT build and I want to run these test against it, but I have to go through all of the poms and update the version. If it was just importing the bom and using a property, it could be retargeted using a command line override. |
I guess I can already override the version on the command line. |
Yeah, you should be able to override it. It definitely doesn't need to have the parent POM for sure. I'll make sure to set it up to allow all dependencies to be overridden so we can test in CI too. |
pull_request: | ||
branches: | ||
- '**' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will add 12 jobs to each PR. I'm not sure if we want to do that, but welcome feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we just run SE 21 on the integration tests on each platform automatically and have a complete integration-test job that can be run manually that covers the latest LTS and the two previous? The full set is running in 6.5 minutes which is not too bad.
b2a8c87
to
c656ab8
Compare
These Windows failures are strange. The BOM is supposed to build as the last module before the integration tests. However, it looks like it's being build second:
The reactor itself looks correct though:
It also didn't fail for me locally in a Windows VM. |
…Payara for testing. Signed-off-by: James R. Perkins <[email protected]>
Signed-off-by: James R. Perkins <[email protected]>
…un the tests.
Short description of what this resolves:
Introduce some integration tests.
Changes proposed in this pull request:
Fixes #580