Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable MultiThreadedBuilder by default. #582

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

rhusar
Copy link
Collaborator

@rhusar rhusar commented Jul 3, 2024

Just throwing it out here as draft to see what people think.

This at least fixes the build logs to be readable on CI.

Copy link
Collaborator

@jamezp jamezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No opposition from me. It would be required to be overridden when integration tests go in as they likely start containers which cannot start at the same time given listening ports.

@rhusar rhusar marked this pull request as ready for review July 3, 2024 14:30
@rhusar
Copy link
Collaborator Author

rhusar commented Jul 3, 2024

No opposition from me. It would be required to be overridden when integration tests go in as they likely start containers which cannot start at the same time given listening ports.

Although, we could probably change those and use a random port?

@jamezp
Copy link
Collaborator

jamezp commented Jul 3, 2024

No opposition from me. It would be required to be overridden when integration tests go in as they likely start containers which cannot start at the same time given listening ports.

Although, we could probably change those and use a random port?

For WildFly, probably. I assume other containers too. It's something we could look at, but it might be taxing to resources when you've got two containers running at the same time. Maybe not though.

@starksm64 starksm64 merged commit 88f9920 into arquillian:master Jul 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants