Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker compose file #176

Closed
simevo opened this issue Dec 5, 2023 · 4 comments · Fixed by #191
Closed

docker compose file #176

simevo opened this issue Dec 5, 2023 · 4 comments · Fixed by #191
Assignees
Labels
ci/cd Continous Integration & Development feature request Request of new features

Comments

@simevo
Copy link

simevo commented Dec 5, 2023

It would make it easier to try out django-ledger if a containerized set up was available. Either here or in https://github.com/arrobalytics/django-ledger-starter

Just docker-compose up then http://localhost:8000/ledger

I see this has been already brought up in the past (#125).

I am happy to contribute a setup similar to this one with adminer service to access the DB.

simevo pushed a commit to simevo/django-ledger-starter that referenced this issue Dec 5, 2023
@simevo
Copy link
Author

simevo commented Dec 5, 2023

I created a prototype here: https://github.com/simevo/django-ledger-starter/tree/dockerize ... but hit #178.

🤔

@elarroba
Copy link
Member

elarroba commented Dec 5, 2023

@simevo I just created a pull request for review... thanks for suggesting this.

@elarroba elarroba added feature request Request of new features ci/cd Continous Integration & Development labels Dec 5, 2023
@elarroba
Copy link
Member

elarroba commented Dec 7, 2023

@simevo Instead of overriding the instructions I think it's best to add a new Docker section with docker-specific instructions. This way the package is documented for non-Docker users as well.

Could you please correct?
Thanks!

@MateehUllah
Copy link
Contributor

@elarroba I created PR kindly review it.

@elarroba elarroba linked a pull request Mar 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Continous Integration & Development feature request Request of new features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants