Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooling] Improve Emission scripts to support testing of dependency updates #136

Open
javamonn opened this issue Nov 28, 2018 · 0 comments

Comments

@javamonn
Copy link
Contributor

In #109 we introduced an initial set of scripts to support testing palette changes in emission locally.

In implementing #135 I realized that it's difficult to test changes involving palette dependencies locally in emission. The added scripts drop the compiled output into emission/node_modules/@artsy/palette (as Metro does not support symlinks), but does not update package artifacts: emission/node_modules/@artsy/palette/node_modules remains the versions of dependencies that the published version of palette is using. This is a little counterintuitive, as I'm used to updating a dependency in a linked package and rebuilding the consumer to test the changes out.

I wasn't able to run yarn install --production manually within emission/node_modules/@artsy/palette/node_modules either after copying over a changed package.json either due to Metro module map errors. I'm not sure but I wonder if it's due to the hard React dependency being incompatible - is there a reason we don't have a peerDependency on React?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant