New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add delay to chart rendering in Chromatic #528

Open

zephraph opened this issue Jun 27, 2019 · 1 comment

Contributor

zephraph commented Jun 27, 2019

We've had some issues where the pie chart will register very-minor differences between chromatic tests.

I believe this is likely a timing issue that can be fixed by adding a delay. If not, we can ignore the story altogether.

Contributor

pvinis commented Jul 16, 2020 •

edited

Loading

Maybe this can help https://www.chromatic.com/docs/animations. I'll link here in the front end practice.

(I didn't know where in jira to make an issue, so I came here and found this issue.)

https://artsy.slack.com/archives/CP9P4KR35/p1594740540000900

ashfurrow added a commit that referenced this issue


          Replaces delay with pausing animations. Fixes #528.

9d8e8e9

Co-authored-by: David Sheldrick <[email protected]>
Co-authored-by: Pavlos Vinieratos <[email protected]> 
Co-authored-by: Mounir Dhahri <[email protected]> 
Co-authored-by: Brian Beckerle <[email protected]>

ashfurrow mentioned this issue

Replaces delay with pausing animations. #749

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment