Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React 16] Use Error Boundaries #1530

Open
6 tasks
eessex opened this issue Jan 10, 2018 · 0 comments
Open
6 tasks

[React 16] Use Error Boundaries #1530

eessex opened this issue Jan 10, 2018 · 0 comments

Comments

@eessex
Copy link
Contributor

eessex commented Jan 10, 2018

https://reactjs.org/blog/2017/07/26/error-handling-in-react-16.html

In React 15, a bug in a component would fail somewhat silently as console errors, but in 16 it brings down the entire tree and displays a WSOD (https://github.com/artsy/publishing/issues/285).

We need to implement the new <ErrorBoundary /> feature to contain these errors to select regions.

Potential sections to have boundaries:

  • SectionContainer
  • SectionList
  • EditContent
  • EditAdmin (and each drop-down panel)
  • EditDisplay (and each drop-down panel)
  • DisplayAdmin drop-down panels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant