Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-bind for <input type="password"> missing #92

Closed
tristanls opened this issue Aug 13, 2012 · 6 comments · Fixed by #99
Closed

data-bind for <input type="password"> missing #92

tristanls opened this issue Aug 13, 2012 · 6 comments · Fixed by #99
Labels

Comments

@tristanls
Copy link
Collaborator

The fix is here:

https://github.com/arturadib/agility/blob/master/agility.js#L579

The line is currently:

else if ($node.is('input:text, textarea')) {

It should be

else if ($node.is('input:text, input:password, textarea')) {

Just need to find some time to add tests and such to make a pull request

@tristanls
Copy link
Collaborator Author

could be duplicate of #82

@tristanls
Copy link
Collaborator Author

This probably has been caused by a fix here: fa20bdc

@arturadib
Copy link
Owner

That sounds right. Happy to review a PR, and it's great to see you back here :)

@codeinabox
Copy link

Has this been merged into the current code? I can't see this fix in 0.1.3

@codeinabox
Copy link

One other thing, I've noticed that Agility doesn't support the new HTML5 input types such as input:email, input:number etc.

@tristanls
Copy link
Collaborator Author

Fixed by #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants