Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about zero123 azimuth angle #339

Open
ug-kim opened this issue Aug 22, 2023 · 0 comments
Open

Question about zero123 azimuth angle #339

ug-kim opened this issue Aug 22, 2023 · 0 comments

Comments

@ug-kim
Copy link

ug-kim commented Aug 22, 2023

Hello, I have some questions about the azimuth angle of zero123.

95f72bb#diff-90e65461624aace29412e4625384cd3a3e3f96731f13b29686bfcc6c34b871b6

In this commit, you change your code like below.
image

However, in the zeor123 paper in supplementary, azimuth is encoded with phi -> [sin(phi), cos(phi)].
(theta is polar, phi is azimuth).
image

What is the difference between these two encodings of azimuth, and why you changed like that?
(two encodings are 1) phi -> [sin(phi), cos(phi)], 2) phi -> [sin(-phi), cos(phi)])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant