[tool.ruff.lint.flake8-tidy-imports] rules in pyproject.toml parent are ignore pyproject.toml child file

[FrancoisMasson1990]

Rules present in pyproject.toml parent file are ignored in the child file one.

Example given

./pyproject.toml

[tool.ruff.lint.flake8-tidy-imports.banned-api]
"typing.List".msg = "Use list instead of typing.List"
"typing.Dict".msg = "Use dict instead of typing.Dict"

./folder_a/pyproject.toml

[tool.ruff]
# Extend the `pyproject.toml` file in the parent directory.
extend = "../pyproject.toml"

[tool.ruff.lint.flake8-tidy-imports.banned-api]
"B".msg = "Don't import B in A"

Typing check are not considered when running poetry ruff check . in the folder_a

[MichaReiser]

Typing check are not considered when running poetry ruff check . in the folder_a

Can you expand on what you mean and maybe share an example python file? That would help me reproduce the issue and, in turn, help you.

[FrancoisMasson1990]

Typing check are not considered when running poetry ruff check . in the folder_a

Can you expand on what you mean and maybe share an example python file? That would help me reproduce the issue and, in turn, help you.

Sure.

in the following folder structure

|
|
pyproject.toml
folder-a
    |-folder_a
        |--- __init__.py
        |--- test.py
   |-pyproject.toml

test.py

from typing import List

Using the following configuration

./pyproject.toml

[tool.ruff.lint.flake8-tidy-imports.banned-api]
"typing.List".msg = "Use list instead of typing.List"
"typing.Dict".msg = "Use dict instead of typing.Dict"

And

./folder_a/pyproject.toml

[tool.ruff]
# Extend the `pyproject.toml` file in the parent directory.
extend = "../pyproject.toml"

[tool.ruff.lint.flake8-tidy-imports.banned-api]
"B".msg = "Don't import B in A"

The error on importing List is ignored.

Note that if [tool.ruff.lint.flake8-tidy-imports.banned-api] rules are missing in ./folder_a/pyproject.toml. (No "B".msg = "Don't import B in A" for example) The error is flagged.

Let me know if it's clearer with the following explanation.

[dhruvmanila]

I think this is an expected behavior because the banned-api value in the nested pyproject.toml will override the one in the parent pyproject.toml. The extend option is to merge the properties from different configuration files.

[FrancoisMasson1990]

I think this is an expected behavior because the banned-api value in the nested pyproject.toml will override the one in the parent pyproject.toml. The extend option is to merge the properties from different configuration files.

Ok but is there a way in that case to merge the banned-api from different configuration file ?

We want to avoid duplicated rules accross different configuration files.
Example given:
"typing.List".msg = "Use list instead of typing.List"

Should be present in only config file and spread accross various sub_folder

[MichaReiser]

Ok but is there a way in that case to merge the banned-api from different configuration file ?

I don't think that's currently possible, and we're aware of this limitation in Ruff's current configuration schema. The problem is that merging the options now makes it impossible to override the banned-apis if there's a need for it.

The solution to this is that we introduce a new sentinel value: "unset" or add a "level" setting to it that can be "ignore", "warn" or "error" so that a sub-configuration can remove (disable) a previous banned api override

This is related to #9872