Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[red-knot] Add implicit-reexport rule for runtime files #16158

Open
dhruvmanila opened this issue Feb 14, 2025 · 0 comments
Open

[red-knot] Add implicit-reexport rule for runtime files #16158

dhruvmanila opened this issue Feb 14, 2025 · 0 comments
Labels
red-knot Multi-file analysis & type inference

Comments

@dhruvmanila
Copy link
Member

Description

Follow-up from #14099 which was closed by #16073 which adds support for re-export conventions in stub files unconditionally.

We should add a new lint rule implicit-reexport which is:

  • Disabled by default
  • When enabled, performs the check for runtime files

For stub files, the implementation is such that it will ignore the symbol if it's not being re-exported which means that the symbol could be unbound as seen in these tests. But, for runtime files, we should be inferring the types correctly.

@dhruvmanila dhruvmanila added the red-knot Multi-file analysis & type inference label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Development

No branches or pull requests

1 participant