Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eq-without-hash (PLW1641) does not check for __hash__ in superclasses #6932

Closed
DetachHead opened this issue Aug 28, 2023 · 6 comments
Closed
Labels
bug Something isn't working type-inference Requires more advanced type inference.

Comments

@DetachHead
Copy link

i noticed this is mentioned in the rule's docs but i'm raising it because i couldn't see an issue for it

@charliermarsh
Copy link
Member

👍 Yeah this is why the rule is in the nursery -- as long as we don't support multi-file analysis, we can't implement it reliably. I'm gonna close as this is basically a known issue that will eventually be solved by multi-file analysis.

@charliermarsh charliermarsh closed this as not planned Won't fix, can't repro, duplicate, stale Aug 28, 2023
@charliermarsh charliermarsh added the bug Something isn't working label Aug 28, 2023
@zanieb zanieb added type-inference Requires more advanced type inference. multifile-analysis and removed type-inference Requires more advanced type inference. labels Aug 28, 2023
@DetachHead
Copy link
Author

wouldn't it make sense to keep the issue open to track it if it's a known issue?

@charliermarsh
Copy link
Member

We could consider creating a central tracking issue (or a tag like @zanieb did here). I just want to avoid piling up a bunch of known issues related to multi-file analysis that can't be worked on individually and make it harder to navigate the issue tracker.

@LefterisJP
Copy link

We could consider creating a central tracking issue (or a tag like @zanieb did here). I just want to avoid piling up a bunch of known issues related to multi-file analysis that can't be worked on individually and make it harder to navigate the issue tracker.

Also hit this one while enabling --preview. It's a useful rule. It found out 1 place we were missing __hash__ but then had 6 false positives due to superclasses.

Added # noqa: PLW1641 # hash implemented by superclass at the false positives for now and keeping the rule.

@DetachHead
Copy link
Author

We could consider creating a central tracking issue

raised #7447

@MichaReiser MichaReiser added type-inference Requires more advanced type inference. and removed multifile-analysis labels Oct 24, 2024
@KotlinIsland
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working type-inference Requires more advanced type inference.
Projects
None yet
Development

No branches or pull requests

6 participants