Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$DATA_LMT not really used (enough) #19

Open
teuben opened this issue Mar 3, 2021 · 2 comments
Open

$DATA_LMT not really used (enough) #19

teuben opened this issue Mar 3, 2021 · 2 comments
Labels
Basically Done all but marked as done

Comments

@teuben
Copy link
Contributor

teuben commented Mar 3, 2021

The dreampy3 toolkit, as well as various places in lmtoy, all use $DATA_LMT, if present. There is some code in lmtlst that hard codes the root path as '/data_lmt', which indeed is a symlink at the UMass machine. However, on personal laptops and desktops this may be hard to do if no admit privileges are given. The first default should thus be $DATA_LMT if present.

There is a lot of code in lmtslr that use a path= in one way or another, and a fair amount of change is needed to implement this.

@teuben teuben added the New No work done yet label Mar 3, 2021
@teuben
Copy link
Contributor Author

teuben commented Mar 7, 2021

all reader.reduce_*() readers now set path=None the default, resulting in the following order of resolution:

  1. path given, use it
  2. $DATA_LMT given, use it
  3. use '/data_lmt', but this may fail on non LMT data reduction computers

@teuben teuben removed the New No work done yet label Mar 7, 2021
@teuben teuben changed the title $DATA_LMT not really used $DATA_LMT not really used (enough) Mar 10, 2021
@teuben teuben added the Basically Done all but marked as done label May 9, 2021
@teuben
Copy link
Contributor Author

teuben commented Jan 6, 2022

Fixed two more cases in

    lmtslr/utils/ifproc_file_utils.py
    lmtslr/utils/roach_file_utils.py

where DATA_LMT was hardcoded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Basically Done all but marked as done
Projects
None yet
Development

No branches or pull requests

1 participant