Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: map methods and fields using mappings #136

Open
viciscat opened this issue Oct 26, 2024 · 4 comments
Open

Suggestion: map methods and fields using mappings #136

viciscat opened this issue Oct 26, 2024 · 4 comments

Comments

@viciscat
Copy link

viciscat commented Oct 26, 2024

Can yall understand Cannot invoke "net.minecraft.class_1087.method_4709()" because "$$7" is null? Cuz I sure can't.

It would be nice to have an option to map vanilla methods and fields with Yarn or Mojang mappings.

(is map the correct verb?)

PS: thanks for making this website btw ❤️

@JulianVennen
Copy link
Member

We already use mappings for stack traces, mapping stuff in specific error messages is a little harder as it likely requires work on each error kind

@viciscat
Copy link
Author

Yea I just realized that the website maps the methods normally while looking at another crash report, sorry about that.
It's just that this one -> https://mclo.gs/g4eGYzo didn't get mapped. (due to the knot// thing I presume)

@JulianVennen
Copy link
Member

Yeah, I think that's new.
I'll look into both of these, probably sometime next week

@JulianVennen
Copy link
Member

#140 resolves the issue with the knot// prefix.
I looked at some things for matching class names in other places like exception messages but found no satisfying solutions.
Yarn mappings can probably be applied with a replace all attitude without false-positives, but that doesn't work for vanilla.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants