Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BBC: Bleadperl v5.41.4 breaks Graphics-Raylib-0.025 (due pp_pack: SvPV_force()...) #5

Open
andk opened this issue Sep 28, 2024 · 0 comments

Comments

@andk
Copy link

andk commented Sep 28, 2024

Fail report: http://www.cpantesters.org/cpan/report/041be644-7c7f-11ef-94fa-40dcd30fa6a7

Bisect points to:

3d831e8998dab40881aa457d1027c4f0fe1ef3d2 is the first bad commit
commit 3d831e8998dab40881aa457d1027c4f0fe1ef3d2
Author: Tony Cook <[email protected]>
Date:   Mon Jul 15 11:45:16 2024 +1000

    pp_pack: SvPV_force() pack(p/P, ...) arguments when writable

    pack("p"/"P") is generally pretty awful, but we document that you
    can pack("P") and then write to the pointer supplied, so make that
    safer by ensuring the PV isn't shared with other SVs.

    Since _force() throws on a READONLY SV, and you shouldn't be writing
    to one, only _force() for a writable SV.

    This is still broken when magic is involved, but we did document it
    as usable.

    Fixes the UUID::FFI part of #22380

    Some other modules (and UUID::FFI itself, really) will need XS
    fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant