Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate user action args #1237

Open
ibelar opened this issue Oct 13, 2021 · 1 comment
Open

Validate user action args #1237

ibelar opened this issue Oct 13, 2021 · 1 comment

Comments

@ibelar
Copy link
Contributor

ibelar commented Oct 13, 2021

Make it possible to use a Data model in order to setup an action arguments.

Advantage:

  • args can be define as Model field;
  • args input can be validate using a model Validator;
@mvorisek
Copy link
Member

mvorisek commented May 27, 2023

Atk4/data UA must be improved to validate the $args againts the $ua->args definition (which needs also an improved phpdoc).

https://github.com/atk4/data/blob/06dc74732a/src/Model/UserAction.php#L144

Then these validations:

can be removed which are even wrong, as isset() will fail with null value like empty date.

This is a priority, so I renamed this issue and moved it into atk4/data.

@mvorisek mvorisek changed the title Allow step executor args step to use a data model Validate user action args Nov 23, 2024
@mvorisek mvorisek transferred this issue from atk4/ui Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants