Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Improve time to find on a large repository by using ripgrep #1075

Closed
1 task done
rafeca opened this issue Mar 19, 2019 · 4 comments
Closed
1 task done

Improve time to find on a large repository by using ripgrep #1075

rafeca opened this issue Mar 19, 2019 · 4 comments
Assignees
Labels
FY2019Q5 atom perf More information: https://github.com/github/pe-atom-log/issues/728

Comments

@rafeca
Copy link
Contributor

rafeca commented Mar 19, 2019

Prerequisites

Description

After seeing the big benefits that ripgrep has brought to fuzzy-finder (more info), we want to explore what would be the impact on the time it takes to find something on a large project (which is not specially fast at the moment).

@rafeca rafeca added the FY2019Q5 atom perf More information: https://github.com/github/pe-atom-log/issues/728 label Mar 19, 2019
@rafeca rafeca self-assigned this Mar 19, 2019
@BurntSushi
Copy link

Please let me know if there's anything I can help with here. Note that ripgrep does have a JSON output mode which should make this task much easier to get right, but its documentation might not be in an obvious place. Here's a link: https://docs.rs/grep-printer/0.1.1/grep_printer/struct.JSON.html

@rafeca
Copy link
Contributor Author

rafeca commented Mar 28, 2019

Thanks @BurntSushi ! Really excited to integrate ripgrep in Atom and get some perf boosts!

I'll take a look at the JSON output docs

@rafeca
Copy link
Contributor Author

rafeca commented May 22, 2019

We have a PR in atom/atom which adds ripgrep as a backend system for the scanner: atom/atom#19348

Once that one gets merged we're going to be able to use it from this package! 🎉

@rafeca
Copy link
Contributor Author

rafeca commented May 28, 2019

Closing this issue, we're going to have an option for ripgrep powered search on Atom v1.39, and hopefully we're going to make it the default one very soon.

Thanks @BurntSushi for such an awesome tool! it's been a delight to integrate it on Atom ❤️

@rafeca rafeca closed this as completed May 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FY2019Q5 atom perf More information: https://github.com/github/pe-atom-log/issues/728
Projects
None yet
Development

No branches or pull requests

2 participants