Add blank line between title and message in commits

[Arcanemagus]

Description

There should be a blank line between the "title" of a commit message and the full description of the message.

Steps to Reproduce

1. Stage a file for committing
2. Write a title (should have a character count on this line), hit enter.
3. Write a description (should have ∞ as the character count)
4. Commit the change
5. View the log

Expected behavior:

Resulting commit message matches what other tools produce.

Actual behavior:

Atom fails to insert a blank line between the title and the detailed description.

Reproduces how often:

100% of the time.

Versions

github@0.0.6

Tested on a custom Atom build based on merging atom/atom@9653399 and atom/atom@4f1b5b7 into atom/atom@1992c17.

Atom : 1.18.0-dev-969a4da6c
Electron: 1.6.9
Chrome : 56.0.2924.87
Node : 7.4.0

git:
git version 2.13.0.windows.1

GitKraken:
v2.5.0

Additional Information

Atom:

git CLI:

Note how it highlights any text placed on that line in orange/red!

As an example of how other implementations handle this, here's GitKraken:

Result:

When viewing the commits on GitHub it handles the lack of a blank line in the same manner as the other tools, but as the blank line is what the official git client does and what other tools do it would be good to follow their lead. It also makes parsing of the messages simpler 😉.

[smashwilson]

A while ago (#351) we'd used the language-git grammar for the commit editor, which provides gentle encouragement to follow the seven rules including this one. We turned it off in #421 because it didn't account for some of the automatic postprocessing we were already doing on the commit message, like automatic soft-wrapping of the commit body.

One idea I have is to include a suitably modified version of language-git's commit message grammar directly within this package.

I'm open to the possibility of adding the newline in our post-processing, too, though.

[Arcanemagus]

Ha, I read that issue, but by the time I saw the package it was already removed 😉.

At least in GitKraken these the title and description sections are treated as two different fields in the interface, and Atom seems to follow this as well with how the character counter changes based on which line you are on, so I don't think users would be too surprised with there being a blank line inserted in the raw commit message.

[BinaryMuse]

I have been in general 👎 on automatic processing of commit messages; I type them like I want them to appear and don't appreciate my tools changing them. I seem to be in the minority though so open to deferring.

[Xapphire13]

Took a stab at the UI component (no post processing, I'm in the same camp as @BinaryMuse on that =]) of this issue here

Which yields:

Issues
If the title line is long enough to wrap, the text box splits the remaining text as another line (so the trailing part of the title isn't formatted like the first line). I can't see any way of knowing this information by inspecting the DOM alone, so it would likely need modification to the editor component itself (unless anyone knows a way of determining a split line via DOM only)