Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filer API #14

Open
aliwalker opened this issue Feb 20, 2019 · 2 comments
Open

Add filer API #14

aliwalker opened this issue Feb 20, 2019 · 2 comments

Comments

@aliwalker
Copy link

Hi, @phal0r !
I've been wandering around seaweedfs since we need some sort of DFS for middle-end architecture. Seaweed is well suited for us, mainly because it provides a set of filer API(To be specific, we'll store wepack's output files to seaweedfs, so directories and file names are particularly important for us).
So I'd like to know if filer API will be added in the future.

@phal0r
Copy link
Collaborator

phal0r commented Feb 20, 2019

Hi @aliwalker ,
I did not work with filer yet, so I have no experience using it. What I read from the docs, I think integration should be quite straight forward.

  • Accept a config param for a filer instance (maybe using namespaces to support different filers)
  • Enhance the API to route filer requests to the filer server

So it is not much to do client-side. Do you have other use cases that are not covered with this approach?

@aliwalker
Copy link
Author

@phal0r , sorry that I didn't have time to reply.

Yes, the filer API is really straight forward to add. I've copied your code directly and modified a bit. See this. It is a framework specific plugin and I added your copy right notice in the source code there.

Since I'm not an experienced engineer yet, my opinions might be immature 😁:

  • Due to simplicity I just decided one filer per server is fine for our needs, and added explicit xxxFiler() methods to distinguish them.
  • I think the original APIs are just fine. No need to changes their functionalities.

Still, I think that Filer APIs could be an enhancement to this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants