Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solr calls with exception handling #2331

Closed

Conversation

prateek05
Copy link
Contributor

fixes #2318

@prateek05
Copy link
Contributor Author

prateek05 commented Oct 31, 2016

There is still one issue remaining. In instances with cross instance search if any of the nodes gets into an error. The result set errors out with the exceptions from the parsing code. The parsing code is way too difficult to introduce any sanity checks :(

None the less unavailability is not a deal breaker. It gets past through that and whatever issue can be reported is reported in the client.

@prateek05
Copy link
Contributor Author

@gordonwoodhull Review

@gordonwoodhull
Copy link
Contributor

I took a quick look but I'm gonna have to take your word on this, as I've never worked with the login code. I'll merge tomorrow unless @s-u objects.

@prateek05
Copy link
Contributor Author

@gordonwoodhull No this one is with the exceptions in solr calls. Login code is resolved.

@gordonwoodhull
Copy link
Contributor

Confirmed it fixes the issue on chusuk. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle SOLR connection issues gracefully
2 participants