Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StreamSettingsPanel: Issues with Dynamic Stream Metadata #424

Open
enricoschroeder opened this issue Jan 15, 2020 · 2 comments · May be fixed by #434
Open

StreamSettingsPanel: Issues with Dynamic Stream Metadata #424

enricoschroeder opened this issue Jan 15, 2020 · 2 comments · May be fixed by #434

Comments

@enricoschroeder
Copy link

Hi,

I'm trying to use the dynamic stream metadata feature introduced in PR 359.

However, if setting DYNAMIC_STREAM_METADATA to true in setXVIZConfig(), StreamSettingsPanel never updates to show any available streams, even though they are correctly displayed in LogViewer (it correctly shows static streams if DYNAMIC_STREAM_METADATA is false). Are there any other configuration or code changes necessary?

Thank You!
@enricoschroeder
Copy link
Author

Ok, I did some debugging.

I found that if DYNAMIC_STREAM_METADATA is true, in componentWillReceiveProps the first if gets triggered a second time with the updated dynamic metadata and sets values=null. However, streamSettings does not change, resulting in the second if to be skipped and values to stay null, which in turn causes the render() method of the component to do nothing.
https://github.com/uber/streetscape.gl/blob/9820c40efe7753a2e16cd72885eb8e876de942e0/modules/core/src/components/stream-settings-panel.js#L163-L174

https://github.com/uber/streetscape.gl/blob/9820c40efe7753a2e16cd72885eb8e876de942e0/modules/core/src/components/stream-settings-panel.js#L187-L196

@enricoschroeder
Copy link
Author

I think in the original PR this logic was changed and it would thus work, however for some reason this change was then reverted back:

#359 (comment)

@kvalev kvalev linked a pull request Apr 5, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show dynamic stream metadata in stream settings panel kvalev/streetscape.gl
1 participant
@enricoschroeder