Skip to content

Commit a0d9e0b

Browse files
committed
Merge pull request psf#2504 from pvanderlinden/bug/2503-resolve-redirect-pass-all-arguments
fix resolve redirect to pass all original arguments
2 parents 5a799dd + 587eb19 commit a0d9e0b

File tree

2 files changed

+5
-12
lines changed

2 files changed

+5
-12
lines changed

AUTHORS.rst

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,4 +156,5 @@ Patches and Suggestions
156156
- Scott Sadler (`@ssadler <https://github.com/ssadler>`_)
157157
- Arthur Darcet (`@arthurdarcet <https://github.com/arthurdarcet>`_)
158158
- Ulrich Petri (`@ulope <https://github.com/ulope>`_)
159-
- Muhammad Yasoob Ullah Khalid <[email protected]> (`@yasoob <https://github.com/yasoob>`_)
159+
- Muhammad Yasoob Ullah Khalid <[email protected]> (`@yasoob <https://github.com/yasoob>`_)
160+
- Paul van der Linden (`@pvanderlinden <https://github.com/pvanderlinden>`_)

requests/sessions.py

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ def merge_hooks(request_hooks, session_hooks, dict_class=OrderedDict):
9090

9191
class SessionRedirectMixin(object):
9292
def resolve_redirects(self, resp, req, stream=False, timeout=None,
93-
verify=True, cert=None, proxies=None):
93+
verify=True, cert=None, proxies=None, **adapter_kwargs):
9494
"""Receives a Response. Returns a generator of Responses."""
9595

9696
i = 0
@@ -193,6 +193,7 @@ def resolve_redirects(self, resp, req, stream=False, timeout=None,
193193
cert=cert,
194194
proxies=proxies,
195195
allow_redirects=False,
196+
**adapter_kwargs
196197
)
197198

198199
extract_cookies_to_jar(self.cookies, prepared_request, resp.raw)
@@ -560,10 +561,6 @@ def send(self, request, **kwargs):
560561
# Set up variables needed for resolve_redirects and dispatching of hooks
561562
allow_redirects = kwargs.pop('allow_redirects', True)
562563
stream = kwargs.get('stream')
563-
timeout = kwargs.get('timeout')
564-
verify = kwargs.get('verify')
565-
cert = kwargs.get('cert')
566-
proxies = kwargs.get('proxies')
567564
hooks = request.hooks
568565

569566
# Get the appropriate adapter to use
@@ -591,12 +588,7 @@ def send(self, request, **kwargs):
591588
extract_cookies_to_jar(self.cookies, request, r.raw)
592589

593590
# Redirect resolving generator.
594-
gen = self.resolve_redirects(r, request,
595-
stream=stream,
596-
timeout=timeout,
597-
verify=verify,
598-
cert=cert,
599-
proxies=proxies)
591+
gen = self.resolve_redirects(r, request, **kwargs)
600592

601593
# Resolve redirects if allowed.
602594
history = [resp for resp in gen] if allow_redirects else []

0 commit comments

Comments
 (0)