Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing in roles.py #545

Closed
5 tasks done
gitwouter opened this issue Oct 31, 2023 · 2 comments · Fixed by #546
Closed
5 tasks done

typing in roles.py #545

gitwouter opened this issue Oct 31, 2023 · 2 comments · Fixed by #546
Labels
bug This points to a verified bug in the code

Comments

@gitwouter
Copy link

Checklist

  • I have looked into the Readme and Examples, and have not found a suitable solution or answer.
  • I have looked into the API documentation and have not found a suitable solution or answer.
  • I have searched the issues and have not found a suitable solution or answer.
  • I have searched the Auth0 Community forums and have not found a suitable solution or answer.
  • I agree to the terms within the Auth0 Code of Conduct.

Description

in roles.py

def remove_permissions(self, id: str, permissions: List[str]) -> Any:
def add_permissions(self, id: str, permissions: List[str]) -> dict[str, Any]:

type annotation should be

permissions: List[dict[str, str]]

Reproduction

this is a development time type checking problem

Additional context

No response

auth0-python version

4.5.0

Python version

3.11

@gitwouter gitwouter added the bug This points to a verified bug in the code label Oct 31, 2023
adamjmcgrath added a commit that referenced this issue Oct 31, 2023
fixes #545 

Signed-off-by: Adam Mcgrath <[email protected]>
@adamjmcgrath
Copy link
Contributor

Hi @gitwouter - thanks for raising this, created #546 to fix

auth0-python version
4.5.0

Out of curiosity - how are you using the types? My understanding is we're not publishing them since #521

@gitwouter
Copy link
Author

gitwouter commented Oct 31, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This points to a verified bug in the code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants