Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update materialize doc with simpler SQL #290

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Update materialize doc with simpler SQL #290

merged 3 commits into from
Dec 19, 2024

Conversation

ecordell
Copy link
Contributor

I think a single select comes off as simpler to grok right now.

The motivation here was that when I was grafting materialize onto an existing project for a demo, I found the ORM that project used made it much easier to build non-union queries.

My only concern with this example is that non-inner joins are much less common and might be confusing in their own right - might be worth coming back to this and expanding on the reason (in this case it's because we don't want to discard rows from the join if they don't have a set_to_set match, since they might have a "direct" member_to_set match.)

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 3:14am

Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. I don't think non-inner joins are too big a hurdle, especially for the users that we'd be expecting to use this.

@ecordell ecordell marked this pull request as draft December 19, 2024 02:33
@ecordell ecordell marked this pull request as ready for review December 19, 2024 03:13
@ecordell ecordell merged commit 578a536 into main Dec 19, 2024
9 checks passed
@ecordell ecordell deleted the ecordell-patch-1 branch December 19, 2024 03:27
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants