Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust restricted api access token generation #297

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

vroldanbet
Copy link
Contributor

the documentation incorrectly described how to
generate a token, suggesting the caller should
provide a value like , when in
fact it should be

It also clarifies the flags needed for enable
restricted api access with static configuration.

Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 5:19pm

the documentation incorrectly described how to
generate a token, suggesting the caller should
provide a value like <prefix>_<hash>, when in
fact it should be <prefix>_<secret>

It also clarifies the flags needed for enable
restricted api access with static configuration.
Copy link
Contributor

@julianleonard123 julianleonard123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vroldanbet vroldanbet requested review from josephschorr and tstirrat15 and removed request for tstirrat15 January 21, 2025 15:03
Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vroldanbet vroldanbet merged commit 230a49f into main Jan 21, 2025
9 checks passed
@vroldanbet vroldanbet deleted the fix-restricted-api-docs branch January 21, 2025 16:44
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants