Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mage test:all should produce a combined code coverage result #1348

Open
jzelinskie opened this issue May 23, 2023 · 2 comments · May be fixed by #2235
Open

mage test:all should produce a combined code coverage result #1348

jzelinskie opened this issue May 23, 2023 · 2 comments · May be fixed by #2235
Labels
area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) good first issue hint/good first issue Someone new could handle this priority/2 medium This needs to be done

Comments

@jzelinskie
Copy link
Member

If we add the -coverprofile flag to ever go test func in magefiles/test.go, we can aggregate them all into a single coverage file in All().

This'll be useful to track (perfect coverage is a non-goal of the project), but is also required for submitting to awesome-go
@jzelinskie jzelinskie added priority/2 medium This needs to be done area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels May 23, 2023
@vroldanbet vroldanbet added hint/good first issue Someone new could handle this good first issue labels Jul 5, 2024
@sephialaureenciaa
Copy link

Hi, i'm interested in contributing to this!

@tstirrat15
Copy link
Contributor

@sephialaureenciaa thanks! have you checked out the CONTRIBUTING file? That should be all you need to get started and we'd welcome a pull request. If there's anything about the contribution guidance that seems like it's missing or confusing we'd also like to hear about it.

@kartikaysaxena kartikaysaxena linked a pull request Feb 4, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) good first issue hint/good first issue Someone new could handle this priority/2 medium This needs to be done
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

magefile: added combined test coverage support for mage test:all kartikaysaxena/spicedb
4 participants
@jzelinskie @tstirrat15 @vroldanbet @sephialaureenciaa