fixup: Store gh_workflow as an annotation

Author: maru-ava

.github/workflows/ci.yml

@@ -93,7 +93,7 @@ jobs:
       - uses: ./.github/actions/install-nix
       - name: Run e2e tests
         shell: bash
-        run: nix develop --command bash -x ./scripts/tests.e2e.kube.sh
+        run: nix develop --impure --command bash -x ./scripts/tests.e2e.kube.sh
         env:
           TMPNET_START_COLLECTORS: ${{ secrets.PROMETHEUS_ID != '' }}
           TMPNET_CHECK_MONITORING: ${{ secrets.PROMETHEUS_ID != '' }}

tests/fixture/tmpnet/kube.go

@@ -74,13 +74,21 @@ func NewNodeStatefulSet(
 	podLabels := map[string]string{
 		"app": name,
 	}
-	ghRepo := ""
+	var (
+		ghRepo     string
+		ghWorkflow string
+	)
 	for label, value := range labels {
 		// gh_repo contains a slash so it is not a valid label. Set it as an annotation instead.
 		if label == "gh_repo" {
 			ghRepo = value
 			continue
 		}
+		// gh_workflow can contain spaces which is not valid in labels. Set it as an annotation instead.
+		if label == "gh_workflow" {
+			ghWorkflow = value
+			continue
+		}
 		podLabels[label] = value
 	}
 	podAnnotations := map[string]string{
@@ -89,6 +97,7 @@ func NewNodeStatefulSet(
 		"prometheus.io/path":   "/ext/metrics",
 		"promtail/collect":     "true",
 		"gh_repo":              ghRepo,
+		"gh_workflow":          ghWorkflow,
 	}
 
 	return &appsv1.StatefulSet{

tests/fixture/tmpnet/yaml/prometheus-agent.yaml

@@ -90,10 +90,11 @@ data:
             target_label: network_uuid
           - source_labels: [__meta_kubernetes_pod_label_node_id]
             target_label: node_id
-          # gh_repo is an annotation because labels can't contain `/`
+          # gh_repo is an annotation because labels can't contain `/` and a repo is typically `[org]/[repo]`
           - source_labels: [__meta_kubernetes_pod_annotation_gh_repo]
             target_label: gh_repo
-          - source_labels: [__meta_kubernetes_pod_label_gh_workflow]
+          # gh_workflow is an annotation because workflows can contain spaces
+          - source_labels: [__meta_kubernetes_pod_annotation_gh_workflow]
             target_label: gh_workflow
           - source_labels: [__meta_kubernetes_pod_label_gh_run_id]
             target_label: gh_run_id

tests/fixture/tmpnet/yaml/promtail-daemonset.yaml

@@ -111,10 +111,11 @@ data:
           target_label: network_uuid
         - source_labels: [__meta_kubernetes_pod_label_node_id]
           target_label: node_id
-        # gh_repo is an annotation because labels can't contain `/`
+        # gh_repo is an annotation because labels can't contain `/` and a repo is typically `[org]/[repo]`
         - source_labels: [__meta_kubernetes_pod_annotation_gh_repo]
           target_label: gh_repo
-        - source_labels: [__meta_kubernetes_pod_label_gh_workflow]
+        # gh_workflow is an annotation because workflows can contain spaces
+        - source_labels: [__meta_kubernetes_pod_annotation_gh_workflow]
           target_label: gh_workflow
         - source_labels: [__meta_kubernetes_pod_label_gh_run_id]
           target_label: gh_run_id