fixup: Stop setting plugin dir for pods

Author: maru-ava

tests/fixture/tmpnet/defaults.go

@@ -63,17 +63,13 @@ func DefaultProcessFlags() FlagsMap {
 }
 
 // Flags appropriate for a node running as a local process
-func DefaultKubeFlags(includePluginDir bool) FlagsMap {
-	flags := FlagsMap{
+func DefaultKubeFlags() FlagsMap {
+	return FlagsMap{
 		config.HTTPHostKey:        "0.0.0.0", // Need to bind to pod IP to ensure kubelet can access the http port for readiness check
 		config.LogDisplayLevelKey: logging.Info.String(),
 		// TODO(marun) Revert
 		config.LogLevelKey: logging.Info.String(), // Assume collection of stdout logs
 	}
-	if includePluginDir {
-		flags[config.PluginDirKey] = "/avalanchego/build/plugins"
-	}
-	return flags
 }
 
 // Flags required by e2e testing

tests/fixture/tmpnet/node_pod.go

@@ -108,11 +108,7 @@ func (p *NodePod) readState(ctx context.Context) error {
 }
 
 func (p *NodePod) SetDefaultFlags() {
-	// Only include the plugin dir if there are subnets to track to ensure an immutable path can be used
-	// TODO(marun) Revisit this comment
-	trackSubnets, err := p.node.Flags.GetStringVal(config.TrackSubnetsKey)
-	includePluginDir := err == nil && len(trackSubnets) > 0
-	p.node.Flags.SetDefaults(DefaultKubeFlags(includePluginDir))
+	p.node.Flags.SetDefaults(DefaultKubeFlags())
 }
 
 // TODO(marun) Maybe better with a timestamp used as input to generateName and include uuid and node id as labels?