You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello, I've been using trm for my personal projects with pgx backend and found out some edge case in trm/v2/manager.go.
Apparently, when a context with external cancel function is passed in Manager.Do, the pgx implementation of a transaction relies on context either have no Done channel or getting the cancel function from manager.
It is kinda fixed in #103 due to changes inside transaction implementations, but the latest release version v2.0.0-rc8 released before it and when I vendor the v2.0.0-rc8 it still contains leak, maybe I am doing something wrong?
The text was updated successfully, but these errors were encountered:
Good day, Alexey!
Sorry for the long reply, I checked and the latest version v2.0.0 contains a fix for the pgx module in awaitDone memory leak, you can use this version.
Hello, I've been using trm for my personal projects with pgx backend and found out some edge case in trm/v2/manager.go.
Apparently, when a context with external cancel function is passed in
Manager.Do
, the pgx implementation of a transaction relies on context either have no Done channel or getting the cancel function from manager.It is kinda fixed in #103 due to changes inside transaction implementations, but the latest release version v2.0.0-rc8 released before it and when I vendor the v2.0.0-rc8 it still contains leak, maybe I am doing something wrong?
The text was updated successfully, but these errors were encountered: