run the linter on each change

Author: barakliato

src/clojureEval.ts

@@ -4,18 +4,17 @@ import { cljConnection } from './cljConnection';
 import { cljParser } from './cljParser';
 import { nreplClient } from './nreplClient';
 import {readBooleanConfiguration} from './utils';
-import { ClojureLintingProvider } from './clojureLintingProvider';
 
 function getAlertOnEvalResult() {
     return readBooleanConfiguration('aletOnEval');
 }
 
-export function clojureEval(outputChannel: vscode.OutputChannel, linter: ClojureLintingProvider): void {    
-    evaluate(outputChannel, linter, false);    
+export function clojureEval(outputChannel: vscode.OutputChannel): void {    
+    evaluate(outputChannel, false);    
 }
 
-export function clojureEvalAndShowResult(outputChannel: vscode.OutputChannel, linter: ClojureLintingProvider): void {    
-    evaluate(outputChannel, linter, true);
+export function clojureEvalAndShowResult(outputChannel: vscode.OutputChannel): void {    
+    evaluate(outputChannel, true);
 }
 
 export function evaluateText(outputChannel: vscode.OutputChannel, 
@@ -37,14 +36,13 @@ export function evaluateText(outputChannel: vscode.OutputChannel,
     });
 }
 
-function evaluate(outputChannel: vscode.OutputChannel, linter: ClojureLintingProvider, showResults: boolean): void {
+function evaluate(outputChannel: vscode.OutputChannel, showResults: boolean): void {
     if (!cljConnection.isConnected()) {
         vscode.window.showWarningMessage('You should connect to nREPL first to evaluate code.');
         return;
     }
 
-    const editor = vscode.window.activeTextEditor;
-    linter.runLinter(editor.document);
+    const editor = vscode.window.activeTextEditor;    
 
     const selection = editor.selection;
     let text = editor.document.getText();

src/clojureLintingProvider.ts

@@ -170,21 +170,21 @@ export class ClojureLintingProvider {
              });		
 	}
 
-	public runLinter(textDocument: TextDocument) {
-		this.diagnosticCollection.delete(textDocument.uri);
-		this.lint(textDocument);
-	}
-
 	public activate(subscriptions: vscode.Disposable[]) {		
 		subscriptions.push(this);
 		this.diagnosticCollection = vscode.languages.createDiagnosticCollection();
 
 		vscode.workspace.onDidOpenTextDocument(this.lint, this, subscriptions);
+
+		vscode.workspace.onDidChangeTextDocument(e=> {
+			
+			this.diagnosticCollection.delete(e.document.uri);
+			this.lint(e.document);
+		});
+
 		vscode.workspace.onDidCloseTextDocument((textDocument)=> {
 			this.diagnosticCollection.delete(textDocument.uri);
 		}, null, subscriptions);
-
-		vscode.workspace.onDidSaveTextDocument(this.runLinter, this);
 	}
 
 	public dispose(): void {

src/clojureMain.ts

@@ -31,12 +31,12 @@ export function activate(context: vscode.ExtensionContext) {
     vscode.commands.registerCommand('clojureVSCode.startNRepl', cljConnection.startNRepl);
 
     const evaluationResultChannel = vscode.window.createOutputChannel('Evaluation results');
-    let linter = new ClojureLintingProvider(evaluationResultChannel);
+    
 
-    vscode.commands.registerCommand('clojureVSCode.eval', () => clojureEval(evaluationResultChannel, linter));
-    vscode.commands.registerCommand('clojureVSCode.evalAndShowResult', () => clojureEvalAndShowResult(evaluationResultChannel, linter));
+    vscode.commands.registerCommand('clojureVSCode.eval', () => clojureEval(evaluationResultChannel));
+    vscode.commands.registerCommand('clojureVSCode.evalAndShowResult', () => clojureEvalAndShowResult(evaluationResultChannel));
     vscode.commands.registerTextEditorCommand('clojureVSCode.formatFile', formatFile);
-    vscode.commands.registerTextEditorCommand('clojureVSCode.reloadNamespace', ()=> { reloadNamespaceCommand(evaluationResultChannel, linter); });
+    vscode.commands.registerTextEditorCommand('clojureVSCode.reloadNamespace', ()=> { reloadNamespaceCommand(evaluationResultChannel); });
     context.subscriptions.push(vscode.languages.registerCompletionItemProvider(CLOJURE_MODE, new ClojureCompletionItemProvider(), '.', '/'));
     context.subscriptions.push(vscode.languages.registerDefinitionProvider(CLOJURE_MODE, new ClojureDefinitionProvider()));
     context.subscriptions.push(vscode.languages.registerHoverProvider(CLOJURE_MODE, new ClojureHoverProvider()));
@@ -48,11 +48,11 @@ export function activate(context: vscode.ExtensionContext) {
     if(getReloadOnFileSave()) {
         vscode.workspace.onDidSaveTextDocument(
             function (textDocument: vscode.TextDocument) {              
-                reloadNamespaceCommand(evaluationResultChannel, linter);
+                reloadNamespaceCommand(evaluationResultChannel);
             }, this);
     }
 
-    	
+    let linter = new ClojureLintingProvider(evaluationResultChannel);
 	linter.activate(context.subscriptions);
 }
 

src/clojureReloadNamespace.ts

@@ -3,22 +3,19 @@ import { cljConnection } from './cljConnection';
 import { cljParser } from './cljParser';
 import { handleError, evaluateText } from './clojureEval';
 import {readBooleanConfiguration} from './utils';
-import { ClojureLintingProvider } from './clojureLintingProvider';
 
 export function getReloadOnFileSave() :boolean {
     return readBooleanConfiguration('autoReloadNamespaceOnSave')
 }
 
 export function reloadNamespaceCommand(        
-    outputChannel: vscode.OutputChannel,
-    linter: ClojureLintingProvider) {
+    outputChannel: vscode.OutputChannel) {
 
     if (!cljConnection.isConnected()) {        
         return;
     }
 
-    const textDocument = vscode.window.activeTextEditor.document;
-    linter.runLinter(textDocument);
+    const textDocument = vscode.window.activeTextEditor.document;    
 
     const fileName = textDocument.fileName;
     if(!fileName.endsWith(".clj")) {